[vlc-devel] [PATCH 1/4] os2: thread: set POLLNVAL instead of returning -1 if not a socket

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> Le 2015-09-15 18:17, KO Myung-Hun a écrit :
>> Rémi Denis-Courmont wrote:
>>> Le 2015-09-13 10:54, KO Myung-Hun a écrit :
>>>> KO Myung-Hun wrote:
>>>>> From: KO Myung-Hun <komh78 at gmail.com>
>>>>>
>>>>> ---
>>>>>  src/os2/thread.c | 32 +++++++++++++++++++++++++-------
>>>>>  1 file changed, 25 insertions(+), 7 deletions(-)
>>>>>
>>>>
>>>> Updated.
>>>
>>> FWIW, I think the patch gives incorrect results if there are more than
>>> one non-socket or bad file descriptors in the set. Bad file descriptors
>>> should never happen, but regular files and pipes definitely do.
>>>
>>
>> Fixed.
> 
> It looks to me that this gives incorrect results on poll(whatever, 0,
> timeout);
> 
> 

Sorry, I failed to see any problems.

What's the problem exactly ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr