[vlc-devel] [vlc-commits] packetizer: mpegvideo: parse color details if present

[Rémi Denis-Courmont]

On Saturday 23 April 2016 14:17:14 Ilkka Ollakka wrote:
> On Mon, Apr 18, 2016 at 02:43:01PM +0200, Rémi Denis-Courmont wrote:
> > Le 2016-04-18 14:18, git at videolan.org a écrit :
> > > +            int8_t color_primaries = p_frag->p_buffer[5];
> > > +            int8_t color_transfer  = p_frag->p_buffer[6];
> > > +            int8_t color_matrix    = p_frag->p_buffer[7];
> > 
> > This is UB if byte values have high order bit set.
> 
> Hi,
> 
> Sorry I'm not quite sure what you mean. If they have high order bit set
> they go negative values, but those bitstreams are anyway out of bounds
> what is defined to be valid and present.

No. It´s UB.

-- 
Rémi Denis-Courmont
http://www.remlab.net/