[vlc-devel] [PATCH 06/21] input/stream: stream-fragments: add vlc_stream_CreateFragmentMRL
Denis Charmet
typx at dinauz.org
Mon Aug 1 11:29:53 CEST 2016
On 2016-08-01 11:18, Filip Roséen wrote:
> In my opinion this certainly is one of those functions where passing
> NULL does not make a lot of sense philosophical speaking, and I am
> semi-against adding checks that simply protects something from invalid
> usage (instead of explicitly saying that such usage is
> ill-formed/undefined).
In my opinion you should *never* trust whatever you get from a public
API.
>
> Nonetheless, I’d be happy to sprinkle a few asserts related to
> arguments passed, and update the documentation to make it more
> explicit about the pre-conditions of using this (and other introduced)
> function(s).
>
> * Do you think that is a suitable middle ground?
Well, I don't like asserts... but that's just me. So suit yourself :)
Regards,
--
Denis Charmet - TypX
Le mauvais esprit est un art de vivre
More information about the vlc-devel
mailing list