[vlc-devel] [vlc-commits] live555: use timer for time-out prevention

[Rémi Denis-Courmont]

Le lauantaina 6. elokuuta 2016, 22.31.26 EEST Filip Roséen a écrit :
> Given that `RTSPClient::sendGetParameterCommand` does not accept it's third
> parameter by reference, simply passing `NULL` instead of `bye` is
> equivalent, and as such the usage of `bye` is redundant.

Possibly. This unchanged from previous code.

> If we do not respect the values from either of the two `rtsp->send*`, might
> this not lead to us waiting indefinitely for a reply that never happens due
> to the sending failing (for whatever reason)?

I don´t know; but likewise, that´s carried over from existing code and not the 
topic of this patch.

> This was, afaik, also present in the legacy implementation (and if the
> problem exists within TimeoutPrevention it exists elsewhere too); but it
> caught my eye when reading your patch.


-- 
Rémi Denis-Courmont
http://www.remlab.net/