[vlc-devel] [vlc-commits] live555: use timer for time-out prevention

[Filip Roséen]

Hi again,

Thank you for the quick reply!

On 16/08/06 23:37, Rémi Denis-Courmont wrote:

> Le lauantaina 6. elokuuta 2016, 22.31.26 EEST Filip Roséen a écrit :
> > Given that `RTSPClient::sendGetParameterCommand` does not accept it's third
> > parameter by reference, simply passing `NULL` instead of `bye` is
> > equivalent, and as such the usage of `bye` is redundant.
> 
> Possibly. This unchanged from previous code.

Indeed.

> > If we do not respect the values from either of the two `rtsp->send*`, might
> > this not lead to us waiting indefinitely for a reply that never happens due
> > to the sending failing (for whatever reason)?
> 
> I don´t know; but likewise, that´s carried over from existing code and not the 
> topic of this patch.
> 

I noted on the previously mentioned since I have been told repeatedly in
the past that carrying over legacy flaws when working on some
implementation is not recommended (and it does not hurt hilighting
potential issues if someone else feel like stepping in to fix them).

Though, the difference might be that it mostly happened to me when I
submitted something to `vlc-devel`, and not post-commit - that distinction
might be key here.

Best Regards,\
Filip Roséen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160806/d6f41886/attachment.html>