[vlc-devel] [PATCH] dash: libmp4: skip meta in moov atom

[Jean-Paul Saman]

On Fri, Aug 19, 2016 at 11:23 AM, Francois Cartegnie <fcvlcdev at free.fr>
wrote:

> Le 19/08/2016 à 03:00, jpsaman at gmail.com a écrit :
> > From: Jean-Paul Saman <jpsaman at videolan.org>
> >
> > MPEG DASH streams with meta in moov atom did not play while other
> players can.
>
> >
> > +    if ( p_box->p_father &&
> > +         p_box->p_father->i_type == ATOM_moov ) /* moov/meta */
> > +        return MP4_ReadBoxContainerChildren( p_stream, p_box, NULL );
> > +
>
> Meta without handler ?
> Do you have a dump tree of this one ?
>

See attachment.


>
> >      const uint32_t stoplist[] = { ATOM_hdlr, 0 };
> >      if ( !MP4_ReadBoxContainerChildren( p_stream, p_box, stoplist ) )
> >          return 0;
> > @@ -3994,6 +3998,7 @@ static const struct
> >      { ATOM_cmov,    MP4_ReadBox_cmov,         0 },
> >      { ATOM_mvhd,    MP4_ReadBox_mvhd,         ATOM_moov },
> >      { ATOM_mvhd,    MP4_ReadBox_mvhd,         ATOM_foov },
> > +    { ATOM_meta,    MP4_ReadBox_meta,         ATOM_moov },
> >      { ATOM_tkhd,    MP4_ReadBox_tkhd,         ATOM_trak },
> >      { ATOM_load,    MP4_ReadBox_load,         ATOM_trak },
> >      { ATOM_mdhd,    MP4_ReadBox_mdhd,         ATOM_mdia },
>
> In every case, this one is not required.
>

Not even for  p_box->p_father->i_type?

>
> Francois
>
>
Kind regards,
Jean-Paul Saman

_______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160819/c3a54e85/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mp4dump.log
Type: text/x-log
Size: 17981 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160819/c3a54e85/attachment.bin>