[vlc-devel] [PATCH] dash: libmp4: skip meta in moov atom

[Francois Cartegnie]

Le 19/08/2016 à 20:00, Jean-Paul Saman a écrit :
> On Fri, Aug 19, 2016 at 11:23 AM, Francois Cartegnie <fcvlcdev at free.fr>
> wrote:
> 
>> Le 19/08/2016 à 03:00, jpsaman at gmail.com a écrit :
>>> From: Jean-Paul Saman <jpsaman at videolan.org>
>>>
>>> MPEG DASH streams with meta in moov atom did not play while other
>> players can.
>>
>>>
>>> +    if ( p_box->p_father &&
>>> +         p_box->p_father->i_type == ATOM_moov ) /* moov/meta */
>>> +        return MP4_ReadBoxContainerChildren( p_stream, p_box, NULL );
>>> +
>>
>> Meta without handler ?
>> Do you have a dump tree of this one ?
>>
> 
> See attachment.

According to the dump, the bug fix is incorrect.
If we want that metadata parsed, we need to match the handler and its
format.

The real bug is that the mp4 demux shouldn't fail when on metadata atom
at this location fails.

Francois