[vlc-devel] [PATCH 1/5] mp4: fix the reading of prhd, equi, cbmp and st3d boxes

[Francois Cartegnie]

Le 05/12/2016 à 14:17, Adrien Maglo a écrit :

> +    uint8_t i_version;
> +    MP4_GET1BYTE( i_version );
> +    if ( i_version != 0 )
> +    {
> +        msg_Warn( p_stream, "'st3d' box with version != 0" );

Useless message, just return and let emit generic parsing failure.

> +        MP4_READBOX_EXIT( 0 );
> +    }

I assume you really have checked that all those atoms are only known in
version 0 in that spec.



> +    VLC_UNUSED( i_flags );

Useless


Francois