[vlc-devel] [PATCH 1/5] mp4: fix the reading of prhd, equi, cbmp and st3d boxes

[Adrien Maglo]

Le 08/12/2016 à 12:32, Francois Cartegnie a écrit :
> Le 05/12/2016 à 14:17, Adrien Maglo a écrit :
>
>> +    uint8_t i_version;
>> +    MP4_GET1BYTE( i_version );
>> +    if ( i_version != 0 )
>> +    {
>> +        msg_Warn( p_stream, "'st3d' box with version != 0" );
>
> Useless message, just return and let emit generic parsing failure.

Ok

>> +        MP4_READBOX_EXIT( 0 );
>> +    }
>
> I assume you really have checked that all those atoms are only known in
> version 0 in that spec.

As far as I know, there is currently only one version of the 
specification which is 0.
Do we want to read this data if we have an unknown version number with 
an unknown data layout?

>> +    VLC_UNUSED( i_flags );

This macro is used at other places in the source file when the data is 
not kept (for example i_dummy in MP4_ReadBox_chpl). Without it a get a 
warning from GCC:

WARNING : ../../modules/demux/mp4/libmp4.c:859: 14:  variable 'i_flags' 
set but not used [-Wunused-but-set-variable]

Best regards,


-- 
MagSoft