[vlc-devel] [PATCH 2/2] playlist/fetcher: do not ignore metadata scope when downloading art

[Marvin Scholz]

On 10 Dec 2016, at 15:09, Filip Roséen wrote:

> Hi Pierre,
>
> On 2016-12-10 01:08, Pierre Ynard wrote:
>
>>> Previously the implementation would unconditionally download art,
>>> these changes make sure that we respect the scope of the fetcher 
>>> being
>>> used.
>>
>> Does this mean that the Art URL returned by any lua playlist script
>> suddenly gets ignored? There will be complaints about that, and it
>> hardly makes sense since typical scripts parse a web page resulting 
>> from
>> deliberate network access, and are allowed by design to make 
>> secondary
>> network requests to fetch the media URL and other metadata.
>
> It will be "ignored" if the user has specified
> `--no-metadata-network-access` and the URL for the art specified is
> not considered "local" (see previous discussion with *Remi* for
> further information on the matteR).
>
> I cannot see any other way to interpret the flag, and the intent has
> always been to block metadata lookup and access for the desribed set
> of entities (when the flag is enabled).

I have the same opinion as Pierre, that this would be wrong. This is not 
what
this flag is intended to do, or if it is, it is incorrectly advertised 
to the user.
The flag is just intended to block searching for unknown metadata, but 
in no way
to prevent external metadata, that is not considered local, to be 
fetched and
would probably confuse a lot of users, me included, if that would be the
new behavior.

If a playlist, title or lua playlist script explicitly states external 
metadata
for an item, it should still be fetched even with 
`--no-metadata-network-access`
IMHO.

What should _not_ happen, is looking it up with external art fetchers 
(google or
other services), if the flag is set.

> […]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161211/426d24ea/attachment.html>