[vlc-devel] [PATCH] auhal: fix 7.1 channel layout for mac (fix #17556)

[Andrii Zui]

Currently AUHAL drops rear surround channels if device layout is set to
`L R C LFE Rls Rrs Ls Rs` because it expects Left Center and Right Center
channels instead (as in MPEG_7_1_A). Setting input_layout to MPEG_7_1_C fixes
this issue.

Note that setting device layout to e.g. `L R C LFE Ls Rs Lc Rc` doesn't help,
because VLC doesn't recognize Lc/Rc channels - they're not present in
i_auhal_channel_mapping.
---
 modules/audio_output/auhal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/audio_output/auhal.c b/modules/audio_output/auhal.c
index 0ea242a..aad4d8a 100644
--- a/modules/audio_output/auhal.c
+++ b/modules/audio_output/auhal.c
@@ -751,7 +751,7 @@ static int StartAnalog(audio_output_t *p_aout, audio_sample_format_t *fmt)
             break;
         case 8:
             if (fmt->i_physical_channels & (AOUT_CHAN_LFE) || currentMinorSystemVersion < 7) {
-                input_layout.mChannelLayoutTag = kAudioChannelLayoutTag_MPEG_7_1_A; // L R C LFE Ls Rs Lc Rc
+                input_layout.mChannelLayoutTag = kAudioChannelLayoutTag_MPEG_7_1_C; // L R C LFE Ls Rs Rls Rrs
 
                 chans_out[0] = AOUT_CHAN_LEFT;
                 chans_out[1] = AOUT_CHAN_RIGHT;
-- 
2.9.3 (Apple Git-75)