[vlc-devel] [PATCH 1/2] core: added sort by date (prepare for playlist fix)

[Filip Roséen]

Hi Marcel,

On 2016-12-15 16:32, Marcel Schnirring wrote:

> After another week passt, asking again for the state of my patch...

Please see the below linked reply (the contents still applies):

 - https://mailman.videolan.org/pipermail/vlc-devel/2016-December/110845.html

I do not have commit access myself, and as such I can only provide
recommendations in terms of getting things merged into the codebase.

Submitting your work to `vlc-devel` in the way which is intended would
surely help merging it, especially given that your previous emails
does not include a proper commit message (nor does it include the
relevant information in regards of *Author*, etc).

Best Regards,\
Filip Roséen

> *Mit freundlichen Grüßen / Kind regards,*
> Marcel Schnirring
> 
> *Heilbronner Strasse 36*
> *76131 Karlsruhe*
> *Deutschland / Germany*
> *Email: ms at marcel-schnirring.de <ms at marcel-schnirring.de>*
> *Mobile: (+49) 178 198 37 61*
> 
> On Thu, Dec 8, 2016 at 10:21 PM, Marcel Schnirring <ms at marcel-schnirring.de>
> wrote:
> 
> > ---
> >  include/vlc_playlist.h |  3 ++-
> >  src/playlist/sort.c    | 14 ++++++++++++--
> >  2 files changed, 14 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/vlc_playlist.h b/include/vlc_playlist.h
> > index 6e42cb5..6a65c80 100644
> > --- a/include/vlc_playlist.h
> > +++ b/include/vlc_playlist.h
> > @@ -186,7 +186,8 @@ struct playlist_t
> >      DEF( SORT_DESCRIPTION )\
> >      DEF( SORT_RATING )\
> >      DEF( SORT_URI )\
> > -    DEF( SORT_DISC_NUMBER )
> > +    DEF( SORT_DISC_NUMBER )\
> > +    DEF( SORT_DATE )
> >
> >  #define DEF( s ) s,
> >  enum
> > diff --git a/src/playlist/sort.c b/src/playlist/sort.c
> > index 588bd35..f241167 100644
> > --- a/src/playlist/sort.c
> > +++ b/src/playlist/sort.c
> > @@ -226,12 +226,22 @@ SORTFN( SORT_ALBUM, first, second )
> >      return i_ret;
> >  }
> >
> > +SORTFN( SORT_DATE, first, second )
> > +{
> > +    int i_ret = meta_sort( first, second, vlc_meta_Date, true );
> > +    /* Items came from the same date: compare the albums */
> > +    if( i_ret == 0 )
> > +        i_ret = proto_SORT_ALBUM( first, second );
> > +
> > +    return i_ret;
> > +}
> > +
> >  SORTFN( SORT_ARTIST, first, second )
> >  {
> >      int i_ret = meta_sort( first, second, vlc_meta_Artist, false );
> > -    /* Items came from the same artist: compare the albums */
> > +    /* Items came from the same artist: compare the dates */
> >      if( i_ret == 0 )
> > -        i_ret = proto_SORT_ALBUM( first, second );
> > +        i_ret = proto_SORT_DATE( first, second );
> >
> >      return i_ret;
> >  }
> > --
> > 2.10.2.windows.1
> >
> >

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161215/c6015ba8/attachment.html>