[vlc-devel] [PATCH 1/2] core: added sort by date (prepare for playlist fix)

[Marcel Schnirring]

I already created the patches via "git format-patch" and sent the emails
via "git send-email"...

Further, I used meaningful commit messages in the subject and set my name
and email correctly...

I am nearly waiting a month for this small commit to be merged...

Seems to be a really complicated process:

   - Preparing the build environment: Several hours with slow internet
   - Understanding the code and finding files which need changes: One to
   two hours
   - Writing the fix and testing it: Half an hour
   - Trying to have this fix applied: More than a month...

*Mit freundlichen Grüßen / Kind regards,*
Marcel Schnirring

On Thu, Dec 15, 2016 at 8:22 PM, Filip Roséen <filip at atch.se> wrote:

> Hi Marcel,
>
> On 2016-12-15 16:32, Marcel Schnirring wrote:
>
>  After another week passt, asking again for the state of my patch...
>
> Please see the below linked reply (the contents still applies):
>
>    - https://mailman.videolan.org/pipermail/vlc-devel/2016-Decemb
>    er/110845.html
>
> I do not have commit access myself, and as such I can only provide
> recommendations in terms of getting things merged into the codebase.
>
> Submitting your work to vlc-devel in the way which is intended would
> surely help merging it, especially given that your previous emails does not
> include a proper commit message (nor does it include the relevant
> information in regards of *Author*, etc).
>
> Best Regards,
> Filip Roséen
>
>  *Mit freundlichen Grüßen / Kind regards,*
>  Marcel Schnirring
>
>  *Heilbronner Strasse 36*
>  *76131 Karlsruhe*
>  *Deutschland / Germany*
>  *Email: ms at marcel-schnirring.de <ms at marcel-schnirring.de>*
>  *Mobile: (+49) 178 198 37 61 <+49%20178%201983761>*
>
>  On Thu, Dec 8, 2016 at 10:21 PM, Marcel Schnirring <ms at marcel-schnirring.de>
>  wrote:
>
>  ---
>   include/vlc_playlist.h |  3 ++-
>   src/playlist/sort.c    | 14 ++++++++++++--
>   2 files changed, 14 insertions(+), 3 deletions(-)
>
>  diff --git a/include/vlc_playlist.h b/include/vlc_playlist.h
>  index 6e42cb5..6a65c80 100644
>  --- a/include/vlc_playlist.h
>  +++ b/include/vlc_playlist.h
>  @@ -186,7 +186,8 @@ struct playlist_t
>       DEF( SORT_DESCRIPTION )\
>       DEF( SORT_RATING )\
>       DEF( SORT_URI )\
>  -    DEF( SORT_DISC_NUMBER )
>  +    DEF( SORT_DISC_NUMBER )\
>  +    DEF( SORT_DATE )
>
>   #define DEF( s ) s,
>   enum
>  diff --git a/src/playlist/sort.c b/src/playlist/sort.c
>  index 588bd35..f241167 100644
>  --- a/src/playlist/sort.c
>  +++ b/src/playlist/sort.c
>  @@ -226,12 +226,22 @@ SORTFN( SORT_ALBUM, first, second )
>       return i_ret;
>   }
>
>  +SORTFN( SORT_DATE, first, second )
>  +{
>  +    int i_ret = meta_sort( first, second, vlc_meta_Date, true );
>  +    /* Items came from the same date: compare the albums */
>  +    if( i_ret == 0 )
>  +        i_ret = proto_SORT_ALBUM( first, second );
>  +
>  +    return i_ret;
>  +}
>  +
>   SORTFN( SORT_ARTIST, first, second )
>   {
>       int i_ret = meta_sort( first, second, vlc_meta_Artist, false );
>  -    /* Items came from the same artist: compare the albums */
>  +    /* Items came from the same artist: compare the dates */
>       if( i_ret == 0 )
>  -        i_ret = proto_SORT_ALBUM( first, second );
>  +        i_ret = proto_SORT_DATE( first, second );
>
>       return i_ret;
>   }
>  --
>  2.10.2.windows.1
>
>  _______________________________________________
>  vlc-devel mailing list
>  To unsubscribe or modify your subscription options:
>  https://mailman.videolan.org/listinfo/vlc-devel
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161221/a89c5c26/attachment.html>