[vlc-devel] [PATCH 1/2] vpx: refactor error handling

[Tristan Matthews]

On Mon, Feb 8, 2016 at 6:23 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On 08 Feb, Tristan Matthews wrote :
>>  static picture_t *Decode(decoder_t *dec, block_t **pp_block)
>>  {
>>      struct vpx_codec_ctx *ctx = &dec->p_sys->ctx;
>> +    vlc_object_t *p_this = (vlc_object_t *)dec;
>
> This cast is a bit ugly, no?

Yes, and it should be VLC_OBJECT(dec);

>
> Are you sure you do need that?

AFAIK, see vlc_Log

-t

>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel