[vlc-devel] [PATCH 1/2] vpx: refactor error handling

[Jean-Baptiste Kempf]

On 08 Feb, Tristan Matthews wrote :
> On Mon, Feb 8, 2016 at 6:23 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> > On 08 Feb, Tristan Matthews wrote :
> >>  static picture_t *Decode(decoder_t *dec, block_t **pp_block)
> >>  {
> >>      struct vpx_codec_ctx *ctx = &dec->p_sys->ctx;
> >> +    vlc_object_t *p_this = (vlc_object_t *)dec;
> >
> > This cast is a bit ugly, no?
> 
> Yes, and it should be VLC_OBJECT(dec);
> 
> >
> > Are you sure you do need that?
> 
> AFAIK, see vlc_Log

Yes, but maybe you can cast just before the log, not in this function?

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device