[vlc-devel] [PATCH] modules: add module_shortcut_exists

[Steve Lhomme]

On Fri, Feb 12, 2016 at 2:28 PM, Thomas Guillem <thomas at gllm.fr> wrote:
>
> On Fri, Feb 12, 2016, at 13:47, Rémi Denis-Courmont wrote:
>> Le 2016-02-12 13:27, Thomas Guillem a écrit :
>> > And remove module_find_by_shortcut that was unused.
>> >
>> > This new function will be used by service discoveries in order to
>> > know if a
>> > protocol is handled by the current vlc instance.
>>
>> Seems as broken as the previous function. As it says, this was but a
>> temporary hack. If it is no longer needed, it should be removed and
>> forgotten.
>
> There are services discoverers that can scan for several protocols.
> What do we do if it discovers an item that is not handled by the current
> instance of VLC because a module is missing ? Should we display it
> anyway ? Should we hide it ?

>From the user point of view, it wouldn't make much sense to display
items we cannot use at all. On the other hand the current
module_exists() is limited to the name of the modules. Hardcoding
modules names for each type of renderer (and each possible module that
claim to handle it) is not a good long term solution. Isn't there a
way to look deeper in the module description the protocols it can
handle ?

>>
>> --
>> Rémi Denis-Courmont
>> http://www.remlab.net/
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel