[vlc-devel] [PATCH] modules: add module_shortcut_exists

Rémi Denis-Courmont remi at remlab.net
Fri Feb 12 14:47:02 CET 2016


Le 2016-02-12 15:28, Thomas Guillem a écrit :
> On Fri, Feb 12, 2016, at 13:47, Rémi Denis-Courmont wrote:
>> Le 2016-02-12 13:27, Thomas Guillem a écrit :
>> > And remove module_find_by_shortcut that was unused.
>> >
>> > This new function will be used by service discoveries in order to
>> > know if a
>> > protocol is handled by the current vlc instance.
>>
>> Seems as broken as the previous function. As it says, this was but a
>> temporary hack. If it is no longer needed, it should be removed and
>> forgotten.
>
> There are services discoverers that can scan for several protocols.
> What do we do if it discovers an item that is not handled by the 
> current
> instance of VLC because a module is missing ? Should we display it
> anyway ? Should we hide it ?

The SD modules are not responsible for what is done with the items.

That responsibility lies with the input thread, the playlist exporter, 
or whatever else ends up consuming the item within the calling 
application.

-- 
Rémi Denis-Courmont
http://www.remlab.net/


More information about the vlc-devel mailing list