[vlc-devel] [PATCH 28/28] include/vlc_codecs.h: deprecation/fix of reserved identifiers
Filip Roséen
filip at atch.se
Sun Feb 21 23:30:01 CET 2016
After a discussiong regarding this patch (with j-b in `#videolan` @ `freenode`)
it has come to my attention that the identifiers that I (mindlessly) wanted to
"deprecate" are coming directly from native windows headers, and as such
deprecation would be __very__ hard.
In other words; this patch should be thrown in the trash.
____.-.____
[___________]
(d|||||||||||b)
`|||TRASH|||`
|||||||||||
|||||||||||
|||||||||||
|||||||||||
`"""""""""`
------------------------------------------------------------------------------
On 16/02/20 23:20, Filip Roséen wrote:
> * renamed include-guard since the old one was a reserved identifier
>
> * replaced comment at `#endif` corresponding to include-guard
>
> * Added preprocessor directives to issue a warning upon usage
> of identifiers that are reserved according to the ISO C Standard.
>
> These checks should be removed when we are confident that they are
> still not used in the codebase. From this on forward the following
> directives should be used (if ever);
>
> - `VLC__SKIP_WAVEFORMATEX` instead of `_WAVEFORMATEX_`
> - `VLC__SKIP_WAVEFORMATEXTENSIBLE` instead of `_WAVEFORMATEXTENSIBLE_`
> - `VLC__SKIP_WAVEHEADER` instead of `_WAVEHEADER_`
> - `VLC__SKIP_BITMAPINFOHEADER` instead of `_VLC_BITMAPINFOHEADER_`
> - `VLC__SKIP_RECT32` instead of `_RECT32_`
> - `VLC__SKIP_REFERENCE_TIME` instead of `_REFERENCE_TIME_`
> - `VLC__SKIP_VIDEOINFOHEADER` instead of `_VIDEOINFOHEADER_`
> - `VLC__SKIP_RGBQUAD` instead of `_RGBQUAD_`
> - `VLC__SKIP_TRUECOLORINFO` instead of `_TRUECOLORINFO_`
> - `VLC__SKIP_VIDEOINFO` instead of `_VIDEOINFO_`
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160221/23e7eb1b/attachment.html>
More information about the vlc-devel
mailing list