[vlc-devel] [PATCH 00/28] Project Cleaner: fix of reserved identifiers (+mini bonus)

Filip Roséen filip at atch.se
Sun Feb 21 23:51:28 CET 2016

These patches can be ignored until we have decided upon a suitable
naming convention for include-guards.

There is currently an ongoing discussion of the matter in `#videolan`,
and I will try to keep this thread updated with the consensus reached.

Jean-Baptiste Kempf proposed the following convention (uppercase):

  - `VLC_${module-name}_${filename-without-ext}_${extension}`

I personally think that it would be a good idea to also include a
trailing underscore to signal that such identifier is never to be used
outside the file it was introduced in.

Stay tuned for updates.


On 16/02/20 23:20, Filip Roséen wrote:

> These patches all boil down to fixing issues where reserved identifiers are
> used, making the codebase ill-formed according to the C (WG14) ISO Standard.
>   - http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1124.pdf (section: 7.1.3/1)
>   - http://www.gnu.org/software/libc/manual/html_node/Reserved-Names.html
>   - http://c-faq.com/decl/namespace.html
> In short, removal/fix of the following type of identifiers:
>   - identifiers in the global scope that start with an underscore
>   - identifiers (everywhere) that start with an underscore followed by a uppercase letter
>   - identifiers (everywhere) that start with two underscores
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160221/1ed7a98e/attachment.html>

More information about the vlc-devel mailing list