[vlc-devel] [RFC PATCH 0/5] Rework VLC Dialog API (Core)

[Thomas Guillem]

This set of patches rework the VLC dialog API.
This is a necessary step to export the VLC dialog API via libvlc.

The diff is not easily readable for dialog.c vlc_dialog.h and external.*, since
everything changed. See the following url for more readability:
 https://github.com/tguillem/vlc/blob/dialog3/src/interface/dialog.c
 https://github.com/tguillem/vlc/blob/dialog3/include/vlc_dialog.h
 https://github.com/tguillem/vlc/blob/dialog3/modules/gui/qt4/dialogs/external.cpp
 https://github.com/tguillem/vlc/blob/dialog3/modules/gui/qt4/dialogs/external.hpp

TODO:
 - sed/dialog_Fatal/vlc_dialog_display_error in the whole code base
 - Implement libvlc dialog api (easy: copy the second part of vlc_dialog.h and
   add lib to all exported functions)
 - Have OSX/IOS ports use dialog via libvlc dialog api
 - Do the same with lua extension dialog.
 
Question:
 - Do we also need to expose extension dialogs via libvlc ?

Thomas Guillem (5):
  intf: rename vlc_dialog enum
  dialog: rework API
  dialog: add an extra test
  gnutls: increase certificate question severity
  securetransport: increase certificate question severity

 include/vlc_dialog.h                              | 438 ++++++++---
 include/vlc_interface.h                           |   4 +-
 include/vlc_objects.h                             |   2 +
 modules/access/dvb/scan.c                         |  43 +-
 modules/access_output/file.c                      |  12 +-
 modules/codec/libass.c                            |  18 +-
 modules/demux/avi/avi.c                           |  48 +-
 modules/gui/qt4/dialogs/external.cpp              | 402 ++++++----
 modules/gui/qt4/dialogs/external.hpp              | 126 +++-
 modules/lua/extension.c                           |  57 +-
 modules/lua/extension.h                           |   2 +-
 modules/lua/extension_thread.c                    |   6 +-
 modules/misc/gnutls.c                             |  28 +-
 modules/misc/securetransport.c                    |  10 +-
 modules/text_renderer/freetype/fonts/fontconfig.c |  22 +-
 src/interface/dialog.c                            | 850 +++++++++++++++++-----
 src/libvlc.c                                      |  11 +
 src/libvlc.h                                      |   4 +-
 src/libvlccore.sym                                |  31 +-
 src/misc/keystore.c                               |  37 +-
 src/misc/update.c                                 |  58 +-
 test/Makefile.am                                  |   3 +
 test/modules/misc/tls.c                           |  34 +-
 test/src/interface/dialog.c                       | 192 +++++
 24 files changed, 1803 insertions(+), 635 deletions(-)
 create mode 100644 test/src/interface/dialog.c

-- 
2.7.0.rc3