[vlc-devel] [PATCH 2/4] picture_pool: make condition a little bit more clear

[Rémi Denis-Courmont]

Le 2016-01-30 10:27, Sergey Radionov a écrit :
> ---
>  src/misc/picture_pool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/misc/picture_pool.c b/src/misc/picture_pool.c
> index 8e72382..fd3dd2a 100644
> --- a/src/misc/picture_pool.c
> +++ b/src/misc/picture_pool.c
> @@ -219,7 +219,7 @@ picture_t *picture_pool_Get(picture_pool_t *pool)
>
>          picture_t *picture = pool->picture[i - 1];
>
> -        if (pool->pic_lock != NULL && pool->pic_lock(picture) != 0) 
> {
> +        if (pool->pic_lock != NULL && pool->pic_lock(picture) !=
> VLC_SUCCESS) {

If you're going to clean this up, please be consistent throughout the 
file.

>              vlc_mutex_lock(&pool->lock);
>              pool->available |= 1ULL << (i - 1);
>              continue;

-- 
Rémi Denis-Courmont
http://www.remlab.net/