[vlc-devel] [PATCH 2/4] picture_pool: make condition a little bit more clear

[sergey radionov]

2016-01-30 20:40 GMT+06:00 Rémi Denis-Courmont <remi at remlab.net>:

> Le 2016-01-30 10:27, Sergey Radionov a écrit :
>
>> ---
>>  src/misc/picture_pool.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/misc/picture_pool.c b/src/misc/picture_pool.c
>> index 8e72382..fd3dd2a 100644
>> --- a/src/misc/picture_pool.c
>> +++ b/src/misc/picture_pool.c
>> @@ -219,7 +219,7 @@ picture_t *picture_pool_Get(picture_pool_t *pool)
>>
>>          picture_t *picture = pool->picture[i - 1];
>>
>> -        if (pool->pic_lock != NULL && pool->pic_lock(picture) != 0) {
>> +        if (pool->pic_lock != NULL && pool->pic_lock(picture) !=
>> VLC_SUCCESS) {
>>
>
> If you're going to clean this up, please be consistent throughout the file.


Do you mean I should replace similar checks over the whole file?



>
>
>              vlc_mutex_lock(&pool->lock);
>>              pool->available |= 1ULL << (i - 1);
>>              continue;
>>
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160130/217bc05a/attachment.html>