[vlc-devel] [PATCH] UTF-16 chapter titles (reworked)

Rémi Denis-Courmont remi at remlab.net
Mon Jul 4 14:50:09 CEST 2016


Le 2016-07-04 14:39, Francois Cartegnie a écrit :
> Le 03/07/2016 à 21:05, Donald Campbell a écrit :
>> -                s->psz_name = strndup( &p_buffer[2], i_len );
>> +                if(*(&p_buffer[2])==(char)255 && 
>> *(&p_buffer[2]+1)==(char)254){ // UTF-16 BOM
>
> No.
>
> buffer read overflow.

The current merged patch has a read overflow. I don't think this 
version had, although it was broken in other ways.

-- 
Rémi Denis-Courmont
http://www.remlab.net/


More information about the vlc-devel mailing list