[vlc-devel] [PATCH] UTF-16 chapter titles (reworked)

[Donald Campbell]

Prior to the memory read, i_len is verified as > 0.  These are null terminated strings so even with a length of 1 the second character would be a null and not past the buffer length.

Or should I not assume the null character is there?

Kind regards,
-DC

> On Jul 4, 2016, at 8:39 AM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
> 
> Le 03/07/2016 à 21:05, Donald Campbell a écrit :
>> -                s->psz_name = strndup( &p_buffer[2], i_len );
>> +                if(*(&p_buffer[2])==(char)255 && *(&p_buffer[2]+1)==(char)254){ // UTF-16 BOM
> 
> No.
> 
> buffer read overflow.
> 
> 
> Francois
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel