[vlc-devel] [PATCH 16/18] gui/qt: fix #17184 (missing entries in context-menu)

[Filip Roséen]

On 2016-07-20 11:44, Filip Roséen wrote:
> On 16/07/20 11:25, Francois Cartegnie wrote:
> 
>> + case ACTION_EXPLORE:
>> + {
>> + return getURI( index ).startsWith( "file:///" );
>> + }
>> You changed scheme without reason.
> 
> What scheme has been changed?

Ah, now I see it - very well spotted (for those as blind as me, there is 
a
trailing slash after "file://" which of course should not be there).


Updated patch
--------------

See the attached patch for an updated patch that fixes the issues
pointed out by Francois and Thomas:

   1. removal of trailing white-space + minor refactor
   2. make ACTION_RENAMENODE respect item->readOnly()
   3. fix nasty typo in regards of ACTION_EXPLORE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gui-qt-fix-17184-missing-entries-in-context-menu.patch
Type: text/x-diff
Size: 5306 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160720/a92104e2/attachment.patch>