[vlc-devel] [PATCH 16/18] gui/qt: fix #17184 (missing entries in context-menu)

[Francois Cartegnie]

Le 20/07/2016 à 12:00, Filip Roséen a écrit :

> -    const PLItem *item = getItem( index );
> +    bool const b_readonly = THEPL->p_root->i_flags & PLAYLIST_RO_FLAG;
> +    AbstractPLItem * item = VLCModel::getItem( index );

That's incorrect. Breaks everything on RO items.

- The playlist root is never RO.
- The item itself can be RO in a non RO node.

This was correct:
> -    case ACTION_CREATENODE:
> -            return ( isTree() && !item->readOnly() );
> -    case ACTION_RENAMENODE:
> -            return ( index != rootIndex() ) && !isLeaf( index ) && !item->readOnly();

Francois