[vlc-devel] [PATCH 6/9] preparser: add playlist_preparser_Cancel

Thomas Guillem thomas at gllm.fr
Thu Jun 2 14:03:44 CEST 2016


On Thu, Jun 2, 2016, at 12:47, Rémi Denis-Courmont wrote:
> Le 2016-06-02 10:33, Thomas Guillem a écrit :
> >> It´s also quite a lot of state to retain and complexity on both side 
> >> for,
> >> AFAIK, little gain.
> >
> > The gain is huge, especially for libvlc. If you parse a network file
> > that is stuck in network I/O, the parser will never receive any
> > stop/interrupt, so you won't be able to parse any more files (local 
> > or
> > network) from it.
> 
> Of couse. I'm pretty sure I said that preparsing network resources was 
> a terrible idea.

I don't see any problem now, especially since you added vlc_interrupt.h.
Theoretically*, any input_thread_t can be stopped without blocking.

*OK, there is an issue with libdsm and upnp modules, I/O are not
interruptible, but this will be fixed soon.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list