[vlc-devel] [PATCH 6/9] preparser: add playlist_preparser_Cancel
remi at remlab.net
Thu Jun 2 14:55:46 CEST 2016
Le 2016-06-02 14:03, Thomas Guillem a écrit :
> On Thu, Jun 2, 2016, at 12:47, Rémi Denis-Courmont wrote:
>> Le 2016-06-02 10:33, Thomas Guillem a écrit :
>> >> It´s also quite a lot of state to retain and complexity on both
>> >> for,
>> >> AFAIK, little gain.
>> > The gain is huge, especially for libvlc. If you parse a network
>> > that is stuck in network I/O, the parser will never receive any
>> > stop/interrupt, so you won't be able to parse any more files
>> > or
>> > network) from it.
>> Of couse. I'm pretty sure I said that preparsing network resources
>> a terrible idea.
> I don't see any problem now, especially since you added
> Theoretically*, any input_thread_t can be stopped without blocking.
Preparsing is serialized for somewhat obvious performance/resource
reasons. So one slow/dead preparse can get the rest stuck, even
potentially local files.
There are also concerns with power management and pay-per-bit,
especially on mobile devices.
> *OK, there is an issue with libdsm and upnp modules, I/O are not
> interruptible, but this will be fixed soon.
More information about the vlc-devel