[vlc-devel] [PATCH] contrib: fix building zlib under mingw

[Jean-Baptiste Kempf]

On 01 Mar, Derek Buitenhuis wrote :
> On 2/29/2016 7:45 PM, Jean-Baptiste Kempf wrote:
> > Not they don't.
> 
> [...]
> 
> > Try:
> > CFLAGS=-brokencrap make -fwin32/Makefile.gcc PREFIX=i686-w64-mingw32-
> 
> Yes, it's called the difference between environment variables and Makefile
> variables. This is how make works, and is standard behavior.

And weirdly, it works for every other library, including the same
library with the normal Makefile.

> Is your argument for it "not working" really that you pass the flag after
> instead of before or in the env? This seems pretty silly, especially to
> use an unsupported method of building to do so.

Unsupported but works everywhere, but this library, only in this win32
Makefile? Also, I don't see where it is unsupported (or supported).
It's trivial to herit from the command line.

> Either that, or you are being unnecessarily terse in your replies, and
> not including some context which would explain why it absolutely must
> use env vars instead of Makefile var assignment.

Sorry, but if you don't see the point of not polluting the env when
compiling 60+ libraries, I'm not sure I can explain better.


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device