[vlc-devel] [PATCH] contrib: fix building zlib under mingw

[Derek Buitenhuis]

On 3/1/2016 1:15 PM, Jean-Baptiste Kempf wrote:
>>> Try:
>>> CFLAGS=-brokencrap make -fwin32/Makefile.gcc PREFIX=i686-w64-mingw32-
>>
>> Yes, it's called the difference between environment variables and Makefile
>> variables. This is how make works, and is standard behavior.
> 
> And weirdly, it works for every other library, including the same
> library with the normal Makefile.

Different != broken.

>> Is your argument for it "not working" really that you pass the flag after
>> instead of before or in the env? This seems pretty silly, especially to
>> use an unsupported method of building to do so.
> 
> Unsupported but works everywhere, but this library, only in this win32
> Makefile? Also, I don't see where it is unsupported (or supported).
> It's trivial to herit from the command line.

It's unsupported because configure explicitly errors out in this
situation. It doesn't get much more clear cut than that. This patch
was specifically to bypass that check.

>> Either that, or you are being unnecessarily terse in your replies, and
>> not including some context which would explain why it absolutely must
>> use env vars instead of Makefile var assignment.
> 
> Sorry, but if you don't see the point of not polluting the env when
> compiling 60+ libraries, I'm not sure I can explain better.

Uh? This is the opposite of polluting the environment. Your complaint was that
it does *not* accept environment variables (instead, requiring Makefile variables
to be set). Unless by the "environment", you don't actually mean the shell
environment?

I admit I'm not sure of the side effects of:

target:
	make -fwin32/Makefile.gcc CFLAGS=$(CFLAGS)

If it pollutes the parent Makefile's CFLAGS variable, then I can understand not
wanting to. I would be surprised if this was the behavior though.

- Derek