[vlc-devel] [PATCH] Get vlc-3.0 git master to build with recent gstreamer

Shlomi Fish shlomif at shlomifish.org
Sat Mar 19 22:22:22 CET 2016

Hi all,

attached is a small patch that fixes a C compilation error on Mageia Linux
v6 (x86-64 in my case) with lib64gstreamer1.0-devel-1.7.91-1.mga6 , and should
work with all previous versions. On the gst's IRC channel, I was told that one
should not include <gst/gstallocator.h> directly and only include <gst/gst.h>,
so that's what I did.

Without this patch I'm getting this output:


  CCLD     libhttps_plugin.la
  CC       codec/gstreamer/libgstdecode_plugin_la-gstdecode.lo
In file included from /usr/include/stdlib.h:24:0,
                 from ../include/vlc_common.h:43,
                 from codec/gstreamer/gstdecode.c:31:
/usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires
compiling with optimization (-O) [-Wcpp] #  warning _FORTIFY_SOURCE requires
compiling with optimization (-O) ^
codec/gstreamer/gstdecode.c: In function ‘gst_vlc_dec_ensure_empty_queue’:
codec/gstreamer/gstdecode.c:115:9: warning: call to ‘harmful_delay’ declared
with attribute warning: use proper event handling instead of short delay msleep
( 15000 ); ^
  CC       codec/gstreamer/libgstdecode_plugin_la-gstvlcpictureplaneallocator.lo
In file included from /usr/include/gstreamer-1.0/gst/gstallocator.h:26:0,
                 from codec/gstreamer/gstvlcpictureplaneallocator.c:27:
/usr/include/gstreamer-1.0/gst/gstmemory.h: In function
‘glib_autoptr_cleanup_GstAllocator’: /usr/include/gstreamer-1.0/gst/gstmemory.h:370:91:
error: ‘gst_object_unref’ undeclared (first use in this
function) /usr/include/gstreamer-1.0/gst/gstmemory.h:370:91: note: each
undeclared identifier is reported only once for each function it appears in
codec/gstreamer/gstvlcpictureplaneallocator.c: In function
codec/gstreamer/gstvlcpictureplaneallocator.c:34:1174: warning: cast from
function call of type ‘long unsigned int’ to non-matching type ‘void
*’ [-Wbad-function-cast] Makefile:15663: recipe for target
'codec/gstreamer/libgstdecode_plugin_la-gstvlcpictureplaneallocator.lo' failed
make[4]: ***
[codec/gstreamer/libgstdecode_plugin_la-gstvlcpictureplaneallocator.lo] Error 1
make[4]: Leaving directory
'/home/shlomif/Download/unpack/multimedia/vlc/vlc-git/modules' Makefile:18524:
recipe for target 'all-recursive' failed make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory
'/home/shlomif/Download/unpack/multimedia/vlc/vlc-git/modules' Makefile:8240:
recipe for target 'all' failed make[2]: *** [all] Error 2 make[2]: Leaving
directory '/home/shlomif/Download/unpack/multimedia/vlc/vlc-git/modules'
Makefile:2257: recipe for target 'all-recursive' failed make[1]: ***
[all-recursive] Error 1 make[1]: Leaving directory
'/home/shlomif/Download/unpack/multimedia/vlc/vlc-git' Makefile:2142: recipe
for target 'all' failed make: *** [all] Error 2
shlomif at telaviv1:~/Download/unpack/multimedia/vlc/vlc-git$ 

< / QUOTE >

I hereby put this patch under
public-domain/CC-Zero/MIT-X11-license/LPGLv2+/any-other-licence. Crediting me
as Shlomi Fish with a link to my home site ( http://www.shlomifish.org/ ) will
be appreciated, but not absolutely required.

Introducing myself to the list:

My real (and legal) name is Shlomi Fish, but on IRC, I am known as "rindolf",
and I decided to allow other people to call me "Rindolf" off IRC because the
name "Shlomi" is hard to fathom for many non-Hebrew speakers. I am an Israeli
software developer and writer who lives in Tel Aviv. I'm a 38 years-old guy
(despite the fact that there's a convention for English names ending with "i"
to be feminine, but my name is Hebrew.)

I've been using the VLC player for several years now after settling
about it after searching for a media player to replace KDE's Amarok after the
painful transition of Amarok to Amarok 2.0 / KDE 4.0. Admittedly, Amarok has
improved since then , but I still use VLC almost all the time.

One thing I like about VLC is that despite its large and comprehensive
feature-set, it is very easy to use and one can get used to the basic
functionality very quickly. I also like the fact that it's not
ultra-minimalistic like many GNOME 3.x apps which I find lacking in
features, annoying to use and unusable. Another thing that I like about VLC is
that it can play most of the multimedia I can throw at it, but admittedly this
feature is not unique to it.

I'm usually using VLC on Mageia Linux x86-64 (see
https://en.wikipedia.org/wiki/Mageia ), either on Mageia v5 or Mageia v6, but
often found it useful to run VLC elsewhere (including Windows). I met some
people who also used VLC on MSWin on various Internet forums, and I think it's
a proof that desktop open source software apps can become really popular if it's
high quality enough. This is the case for VLC and yet I don't encourage VLC (or
any other project) to rest on its laurels.

So far my contribution to VLC has been on the bug tracker (bug reports , QA,
testing and some patches) and the IRC channel, as well as maintaining the VLC
packages on Mageia. I hope I can contribute more, but I cannot promise anything.

Anyway, you are welcome to visit my personal web site
( http://www.shlomifish.org/ ) where I have written many online resources
including stories, humorous bits, collections of factoids, aphorisms and quotes,
essays, presentations, open source software, small and hand-maintained 
directories of software of various categories, some not-too-good attempts at
computer art, some mathematical or logical puzzles or riddles, and some
information about myself (including a frequently-asked-questions (FAQ) list). I
also maintain some other sites and have some blogs and other social media


Regards and keep up the good work,

	Shlomi Fish

Shlomi Fish       http://www.shlomifish.org/
Interview with Ben Collins-Sussman - http://shlom.in/sussman

Chuck Norris can convince everyone that the colour of the bikeshed should be
his favourite colour.
    — http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/

Please reply to list if it's a mailing list post - http://shlom.in/reply .
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc-git1.diff
Type: text/x-patch
Size: 564 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160319/0a808975/attachment.bin>

More information about the vlc-devel mailing list