[vlc-devel] [PATCH] Get vlc-3.0 git master to build with recent gstreamer

[Shlomi Fish]

Hi all,

On Sat, 19 Mar 2016 23:22:22 +0200
Shlomi Fish <shlomif at shlomifish.org> wrote:

> Hi all,
> 
> attached is a small patch that fixes a C compilation error on Mageia Linux
> v6 (x86-64 in my case) with lib64gstreamer1.0-devel-1.7.91-1.mga6 , and should
> work with all previous versions. On the gst's IRC channel, I was told that one
> should not include <gst/gstallocator.h> directly and only include <gst/gst.h>,
> so that's what I did.
> 

I didn't receive a reply to this post with a patch, and it has been 4 days
and there were replies to other patches. Can you please look into it?

Regards,

	Shlomi Fish

> Without this patch I'm getting this output:
> 
> < QUOTE >
> 
>   CCLD     libhttps_plugin.la
>   CC       codec/gstreamer/libgstdecode_plugin_la-gstdecode.lo
> In file included from /usr/include/stdlib.h:24:0,
>                  from ../include/vlc_common.h:43,
>                  from codec/gstreamer/gstdecode.c:31:
> /usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires
> compiling with optimization (-O) [-Wcpp] #  warning _FORTIFY_SOURCE requires
> compiling with optimization (-O) ^
> codec/gstreamer/gstdecode.c: In function ‘gst_vlc_dec_ensure_empty_queue’:
> codec/gstreamer/gstdecode.c:115:9: warning: call to ‘harmful_delay’ declared
> with attribute warning: use proper event handling instead of short delay
> msleep ( 15000 ); ^
>   CC
> codec/gstreamer/libgstdecode_plugin_la-gstvlcpictureplaneallocator.lo In file
> included from /usr/include/gstreamer-1.0/gst/gstallocator.h:26:0, from
> codec/gstreamer/gstvlcpictureplaneallocator.c:27: /usr/include/gstreamer-1.0/gst/gstmemory.h:
> In function
> ‘glib_autoptr_cleanup_GstAllocator’: /usr/include/gstreamer-1.0/gst/gstmemory.h:370:91:
> error: ‘gst_object_unref’ undeclared (first use in this
> function) /usr/include/gstreamer-1.0/gst/gstmemory.h:370:91: note: each
> undeclared identifier is reported only once for each function it appears in
> codec/gstreamer/gstvlcpictureplaneallocator.c: In function
> ‘gst_vlc_picture_plane_allocator_get_type’:
> codec/gstreamer/gstvlcpictureplaneallocator.c:34:1174: warning: cast from
> function call of type ‘long unsigned int’ to non-matching type ‘void
> *’ [-Wbad-function-cast] Makefile:15663: recipe for target
> 'codec/gstreamer/libgstdecode_plugin_la-gstvlcpictureplaneallocator.lo'
> failed make[4]: ***
> [codec/gstreamer/libgstdecode_plugin_la-gstvlcpictureplaneallocator.lo] Error
> 1 make[4]: Leaving directory
> '/home/shlomif/Download/unpack/multimedia/vlc/vlc-git/modules'
> Makefile:18524: recipe for target 'all-recursive' failed make[3]: ***
> [all-recursive] Error 1 make[3]: Leaving directory
> '/home/shlomif/Download/unpack/multimedia/vlc/vlc-git/modules' Makefile:8240:
> recipe for target 'all' failed make[2]: *** [all] Error 2 make[2]: Leaving
> directory '/home/shlomif/Download/unpack/multimedia/vlc/vlc-git/modules'
> Makefile:2257: recipe for target 'all-recursive' failed make[1]: ***
> [all-recursive] Error 1 make[1]: Leaving directory
> '/home/shlomif/Download/unpack/multimedia/vlc/vlc-git' Makefile:2142: recipe
> for target 'all' failed make: *** [all] Error 2
> shlomif at telaviv1:~/Download/unpack/multimedia/vlc/vlc-git$ 
> 
> 
> < / QUOTE >
> 
> I hereby put this patch under
> public-domain/CC-Zero/MIT-X11-license/LPGLv2+/any-other-licence. Crediting me
> as Shlomi Fish with a link to my home site ( http://www.shlomifish.org/ ) will
> be appreciated, but not absolutely required.
> 


-- 
-----------------------------------------------------------------
Shlomi Fish       http://www.shlomifish.org/
http://shlomifishswiki.branchable.com/Encourage_criticism_and_try_to_get_offended/

Chuck Norris is the reason why OpenBSD is called OpenBSD. They wanted to
call it LockedDownBSD but couldn't find a way to keep Chuck Norris out!
(By Andrew Brehm) — http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/

Please reply to list if it's a mailing list post - http://shlom.in/reply .