[vlc-devel] [PATCH] dvdnav: only read the auto-detected main title of the DVD when the dvdnav-main-feature option is used

Petri Hintukainen phintuka at gmail.com
Tue Mar 22 10:08:31 CET 2016


On ti, 2016-03-22 at 08:30 +0200, Rémi Denis-Courmont wrote:
> Le 2016-03-21 16:51, Adrien Maglo a écrit :
> > This should allow to skip menus
> 
> We already have an option to skip menus. We can't add another one 
> because hardly anybody will figure out the differences.

Current method does not work with all DVDs.

> This work-around 
> is probably fine and well for ripping software, but I think it is 
> unsuitable for a media player.

Looks like this code is used to work around some kind of anti-ripping
"DRM" when playing the disc without menus. This could be another reason
to not add it to VLC ...

It is also quite much code. If it is useful for both HB and VLC, it
should probably go to libdvdnav.

> Also this plugin is LGPLv2.1, so can't add GPLv2 code there.

Resulting binary is still GPL ? (the plugin is linked against GPLv2+
libdvdnav).

Anyway, GPL wouldn't be problem if the code was added to libdvdnav.


- Petri


More information about the vlc-devel mailing list