[vlc-devel] [PATCH] dvdnav: only read the auto-detected main title of the DVD when the dvdnav-main-feature option is used
jb at videolan.org
Tue Mar 22 10:17:33 CET 2016
On 22 Mar, Petri Hintukainen wrote :
> On ti, 2016-03-22 at 08:30 +0200, Rémi Denis-Courmont wrote:
> > Le 2016-03-21 16:51, Adrien Maglo a écrit :
> > > This should allow to skip menus
> > We already have an option to skip menus. We can't add another one
> > because hardly anybody will figure out the differences.
> Current method does not work with all DVDs.
Yes. Many DVDs go to the wrong menu, when we skip menus.
> > This work-around
> > is probably fine and well for ripping software, but I think it is
> > unsuitable for a media player.
> Looks like this code is used to work around some kind of anti-ripping
> "DRM" when playing the disc without menus. This could be another reason
> to not add it to VLC ...
Well, it's also useful when you want to read directly the movie, without
waiting for the menus, a bit like we do on blurays.
It's also often requested for accesibility reasons, since DVD menus are
almost never accessible.
> It is also quite much code. If it is useful for both HB and VLC, it
> should probably go to libdvdnav.
I kind of agree, yes.
> > Also this plugin is LGPLv2.1, so can't add GPLv2 code there.
> Resulting binary is still GPL ? (the plugin is linked against GPLv2+
> Anyway, GPL wouldn't be problem if the code was added to libdvdnav.
With my kindest regards,
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
More information about the vlc-devel