[vlc-devel] [PATCH 0/1] qt: prevent setMinimalView() from sizing incorrectly on fullscreen exit

Darrell Walisser darrell.walisser at gmail.com
Tue Mar 22 16:49:18 CET 2016

On Tue, Mar 22, 2016 at 2:28 AM, Rémi Denis-Courmont <remi at remlab.net>

> Le 2016-03-19 19:58, Darrell Walisser a écrit :
>> The bug that I am attempting to fix is the one where if you make the
>> window fullscreen, when it returns to normal its size is now the size
>> of the screen and not the original size.
> Picking the correct size when going from fullscreen to normal window mode
> is the job of the window manager. Don't force a size; problem solved.
> This is precisely what the patch does - it does not allow our code to
change the window size when switching to/from fullscreen, it is qt's job to
manage that.

> As I already wrote, the UI should not even care whether it's fullscreen or
> normal mode (a normal window of the size of the screen should behave the
> same as a fullscreen window).

Are you suggesting that every call to check window state (isFullscreen(),
isMaximized(), ...) be removed, since the UI should not care about it?

> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160322/5a4fe39e/attachment.html>

More information about the vlc-devel mailing list