[vlc-devel] [PATCH 0/1] qt: prevent setMinimalView() from sizing incorrectly on fullscreen exit

Rémi Denis-Courmont remi at remlab.net
Tue Mar 22 19:24:33 CET 2016


Le 2016-03-22 17:49, Darrell Walisser a écrit :
> Are you suggesting that every call to check window state
> (isFullscreen(), isMaximized(), ...) be removed, since the UI should
> not care about it?

Actually yes. The only valid case for resizing is if trying to adapt to 
new video size (and not every user agrees there). You don't need to 
check for window status there, and in fact you should not because the 
check fundamentally is subject to race conditions. You just ask to 
resize regardless of the window mode, and forget about it.

If you later get a resize event, then and only then update the layout.

-- 
Rémi Denis-Courmont
http://www.remlab.net/


More information about the vlc-devel mailing list