[vlc-devel] [PATCH 0/1] qt: prevent setMinimalView() from sizing incorrectly on fullscreen exit
darrell.walisser at gmail.com
Tue Mar 22 21:43:26 CET 2016
On Tue, Mar 22, 2016 at 2:24 PM, Rémi Denis-Courmont <remi at remlab.net>
> Le 2016-03-22 17:49, Darrell Walisser a écrit :
>> Are you suggesting that every call to check window state
>> (isFullscreen(), isMaximized(), ...) be removed, since the UI should
>> not care about it?
> Actually yes. The only valid case for resizing is if trying to adapt to
> new video size (and not every user agrees there).
I agree it would be better if these checks are removed, they will always be
subject to races such as this. However there are a bunch of these checks,
I don't really get the motivation for doing them. Mostly it seems they
want to avoid changing the size of the video viewport when a toolbar or
other UI element is hidden (by resizing the parent window), but I don't see
what the big deal is with letting it grow or shrink.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel