[vlc-devel] [RFC-PATCH] core/audio_output: do not drop (late) audio blocks if it would cause silence

[Rémi Denis-Courmont]

On Thursday 12 May 2016 19:31:40 Filip Roséen wrote:
> > I do not think that comparing duration and delay makes any
> > mathematical/physical sense. The result will be even more arbitrary than
> > it
> > currently is.
> 
> Since we got functionality in order to support resampling (to shrink the
> drift while maintaining playback), it should probably be used under
> circumstances as what is mentioned; or well, that was what went through my
> head when I wrote the patch.
> 
> The duration is just as much part of the entity as the PTS, and if one is
> used to make decisions about potentially discarding the entity itself, I'd
> say it is equally safe to use the other.

In this case the duration is *only* an implementation detail of the decoder, 
or possibly the demuxer.

Stating the obvious here, but if you want to cut at AOUT_MAX_PTS_DELAY, then 
it´s not the length you should be looking at. It´s the start (pts) and the end 
(pts + length).

-- 
Rémi Denis-Courmont
http://www.remlab.net/