[vlc-devel] [RFC PATCH] playlist: don't open failing items in loop

[Thomas Guillem]

On Tue, May 24, 2016, at 11:09, Filip Roséen wrote:
> One immediate reaction:


>  * if we have a playlist set to loop that contains one item which
>    result in ERROR_S, this patch will completely stop the playback -
>    even if there are other playable items in the list.
 
No, this will prevent the current failing item to be opened
automatically. Users will be still able to manually open it.
This don't prevent next items to be opened too.
 
>> If “Repeat All” or “Repeat current Item” option are set. The same
>> failing item will be opened in loop.
> This might be what most expect us to do.
> I do not think that looping items should depend on whether there is an
> error when we try to play them, because there is nothing saying that
> the error will remain next time we try to do it.
> We should trust that the user knows what it has asked us to do, and
> even assume that any input that we are asked to play should be played
> (even if this results in an error). Proving that the underlying
> bytestream does not change before the next time we theoretically would
> have played the item is impossible, and we can also not prove that an
> access that fails one time, always will fail.
> One alternative way to handle this issue *might* be to have the playlist-
> thread temporarily “sleep” (in terms of playing next item) for a
> logarithmic (increasing) duration of time it if notice that no item in
> the current list can be played.
 
I like this idea.
 
>> This is not fixing every case: In general, EsOut will fail because of
>> an unknown/bad codec and the “state” event will be END_S (and not
>> ERROR_S).
> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160524/f25c5e03/attachment.html>