[vlc-devel] fix #14586 (6f3e18d5) leads to crash on Android

[Andrey Gursky]

On Sun, 29 May 2016 11:29:05 +0300
Rémi Denis-Courmont <remi at remlab.net> wrote:

> On Sunday 29 May 2016 03:58:51 Andrey Gursky wrote:
> > > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Fri May
> > > 27 01:13:57 2016 +0300| [6f3e18d534e4fcfeeba6e9b8051ec0db1ea1b3c8] |
> > > committer: Rémi Denis-Courmont
> > > 
> > > android: use generic condition variable and wait (fix #14586)
> > > 
> > > > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6f3e18d534e4fcfee
> > > > ba6e9b8051ec0db1ea1b3c8
> > Hi,
> > 
> > I did a (manual) git bisect and found out, that this commit leads to
> > crash on Android. It is enough to start playing video and then to press
> > "back" smartphone button (to stop playing and get back to the file
> > browser) to crash VLC.
> 
> Stack trace or there is no bug.

Rémi,

considering src/android/thread.c:

static __thread struct vlc_thread *thread = NULL;

vlc_thread_t vlc_thread_self (void)
{
    return thread;
}

void vlc_control_cancel(int cmd, ...)
{
    vlc_thread_t th = vlc_thread_self();
    va_list ap;
//...
}

I don't see where this TLS variable "thread" is assigned before call to
vlc_control_cancel(). 

Regards,
Andrey