[vlc-devel] fix #14586 (6f3e18d5) leads to crash on Android

Rémi Denis-Courmont remi at remlab.net
Sun May 29 20:43:38 CEST 2016


On Sunday 29 May 2016 20:31:37 Andrey Gursky wrote:
> considering src/android/thread.c:
> 
> static __thread struct vlc_thread *thread = NULL;
> 
> vlc_thread_t vlc_thread_self (void)
> {
>     return thread;
> }
> 
> void vlc_control_cancel(int cmd, ...)
> {
>     vlc_thread_t th = vlc_thread_self();
>     va_list ap;
> //...
> }
> 
> I don't see where this TLS variable "thread" is assigned before call to
> vlc_control_cancel().

TBH, that it´s not hard to find by looking for "thread =", and it has not 
changed in 3 years.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list