[vlc-devel] [PATCH] demux/avformat: fix 17575: fix return-value of IORead

Filip Roséen filip at atch.se
Tue Nov 1 15:02:56 CET 2016


On 2016-11-01 14:01, Filip Roséen wrote:

> av_read_frame expects 0 to be returned on end-of-file, and negative
> values are reserved for fatal stream-errors. The previous
> implementation would return -1 upon EOF (vlc_stream_Read returning 0),
> causing premature EOF from modules/demux/avformat/demux.c:Demux.
> These changes make sure that we honor the contract associated with the
> read-callback, and that we only return -1 if there is a fatal error.
> fixes #17574

I noticed that the commit-title of the patch in which this email is a
reply to inaccurately states `"17575"` in the title, instead of

Attached is a patch where this is fixed, though the contents of the
patch is the same as the previously submitted version (only the commit
message has been updated to not refer to the wrong ticket).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161101/dd6ed446/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-demux-avformat-fix-17574-fix-return-value-of-IORead.patch
Type: text/x-diff
Size: 1291 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161101/dd6ed446/attachment.patch>

More information about the vlc-devel mailing list