[vlc-devel] [vlc-commits] tests/tls: Disable checks for ALPN on apple platforms

[Rémi Denis-Courmont]

Le tiistaina 1. marraskuuta 2016, 15.12.29 EET David Fuhrmann a écrit :
> vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Tue Nov  1
> 14:35:08 2016 +0100| [784ab6ce693675fb554060d1e1f8d194c354e3ff] |
> committer: David Fuhrmann
> 
> tests/tls: Disable checks for ALPN on apple platforms

Disabling tests because of a true positive failure? You have got to be 
kidding. Even a fresh IT graduate would know better than that.

> On Apple platforms, ALPN does not work as securetransport does
> not provide any public API for that. So do not check for that
> feature until support is added.
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=784ab6ce693675fb554
> > 060d1e1f8d194c354e3ff
> ---
> 
>  test/modules/misc/tls.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/test/modules/misc/tls.c b/test/modules/misc/tls.c
> index 60898c6..a2ddbf0 100644
> --- a/test/modules/misc/tls.c
> +++ b/test/modules/misc/tls.c
> @@ -201,9 +201,13 @@ int main(void)
>      answer = 1;
>      val = securepair(&th, &tls, alpnv, &alp);
>      assert(val == 0);
> +
> +    /* SecureTransport, used on apple platforms, does not support ALPN */
> +#ifndef __APPLE__
>      assert(alp != NULL);
>      assert(!strcmp(alp, "bar"));
>      free(alp);
> +#endif

Oh and not only it removes a valid test cases, but it obviously introduces a 
leak if GnuTLS is used (which is perfectly possible on MacOS).

> 
>      /* Do some I/O */
>      char buf[12];
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits


-- 
Rémi Denis-Courmont
http://www.remlab.net/