[vlc-devel] [RFC] demux/mp4: fix 17584: signal error if ReadBox_default fails

[Francois Cartegnie]

Le 01/11/2016 à 03:03, Filip Roséen a écrit :

> diff --git a/modules/demux/mp4/libmp4.c b/modules/demux/mp4/libmp4.c
> index 5ea8f8a..8dcf96a 100644
> --- a/modules/demux/mp4/libmp4.c
> +++ b/modules/demux/mp4/libmp4.c
> @@ -4001,7 +4001,7 @@ static int MP4_ReadBox_default( stream_t *p_stream, MP4_Box_t *p_box )
>              default:
>                  msg_Warn( p_stream,
>                            "unknown handler type in stsd (incompletely loaded)" );
> -                return 1;
> +                return 0;
>          }
>      }
>  
> @@ -4016,7 +4016,7 @@ unknown:
>                  (char*)&p_box->i_type+1 );
>      p_box->e_flags |= BOX_FLAG_INCOMPLETE;
>  
> -    return 1;
> +    return 0;
>  }
>  
>  /**** ------------------------------------------------------------------- ****/
> 


Fix would hide from tree complete but unknown boxes and bring regressions.

Has been properly fixed.

Francois