[vlc-devel] [RFC] demux/mp4: fix 17584: signal error if ReadBox_default fails

Filip Roséen filip at atch.se
Fri Nov 4 11:25:52 CET 2016



On 2016-11-04 11:16, Francois Cartegnie wrote:

> Le 01/11/2016 à 03:03, Filip Roséen a écrit :
> 
> > diff --git a/modules/demux/mp4/libmp4.c b/modules/demux/mp4/libmp4.c
> > index 5ea8f8a..8dcf96a 100644
> > --- a/modules/demux/mp4/libmp4.c
> > +++ b/modules/demux/mp4/libmp4.c
> 
> 
> Fix would hide from tree complete but unknown boxes and bring regressions.

Thank you for your reply, but I am not sure I completely understand
what you are referring to. Could you elaborate the explanation?

>From what I can tell the unknown box would simply be discarded if it
could not be parsed, or are you saying that the changes would cause
parsing to stop completely?

> Has been properly fixed.
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161104/8b59b1f5/attachment.html>


More information about the vlc-devel mailing list