[vlc-devel] [PATCH 0/2] demux/subtitle: fix BOM + line-peeking

[Filip Roséen]

These two patches addresses the problem described in the below linked
ticket:

 - https://trac.videolan.org/vlc/ticket/17602

In short `demux/subtitle_helpers.h:peek_Readline` has been replaced by
a new function which has the same functionality, though properly
handles the initial BOM of a stream (by making sure that we parse it
when required (when asking for more peeked data))

In the future my vote goes towards either supporting this
functionality in the core, or simply remove line-peeking from
`demux/subtitle`.

Having a fixed limit of `N` bytes instead of `N` lines in
`demux/subtitle` would allow for a far simpler implementation, though
such change is easier to do as part of a bigger refactor (since
`modules/demux/subtitle.c` currently is not looking too good).

Filip Roséen (2):
  demux/subtitles: add new implementation for line-peeking
  demux/subtitles: fix 17602: replace usage of legacy line-peeking

 modules/demux/subtitle.c        | 10 +++--
 modules/demux/subtitle_helper.h | 87 ++++++++++++++++++++++++++++++++---------
 modules/demux/vobsub.c          | 18 ++++++---
 3 files changed, 86 insertions(+), 29 deletions(-)

------------------------------------------------------------------------

"bom" in Swedish can be translated to "bar" (as in a "long rigid piece
of wood, metal, or similar material"). "Bar" can, of course, also
refer to a place of drinking (same as in English). With that said,
here's a beer:

                                ~  ~
                              ( o )o)
                             ( o )o )o)
                           (o( ~~~~~~~~o
                           ( )' ~~~~~~~'
                           ( )|)       |-.
                             o|     _  |-. \
                             o| |_||_) |  \ \
                              | | ||_) |   | |
                             o|        |  / /
                              |        |." "
                              |        |- '
                              .========.   mb

    src; http://www.chris.com/ascii/index.php?art=food%20and%20drink/beer

-- 
2.10.2