[vlc-devel] [PATCH 2/2] lua/libs/input: add URL property to metadata

Filip Roséen filip at atch.se
Sun Nov 6 19:30:42 CET 2016


Hi,

On 2016-11-06 19:25, Pierre Ynard wrote:

> > These changes adds "URL" as a property to the metadata-table,
> > containing what the name implies.
> 
> I'm not too excited by adding fields that are not metadata i.e.
> arbitrary descriptive strings, to the lua metadata array. And there is
> already a URL metadata field with an arbitrary value relating to the
> content, so that would be confusing.

When I noticed that `"filename"` was there I thought that maybe there
was a exception to the "rule" regarding what should be in the metadata
table. Though I fully agree with you.


> Anyway, I think the functionality is already available through
> vlc.input.item():uri()

That is a very good point, as such I agree with you that the second
patch should be discarded (in favor of using `vlc.input.item():uri()`).

Thanks,\
Filip
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161106/d80301c9/attachment.html>


More information about the vlc-devel mailing list