[vlc-devel] [PATCH] xvideo: fallback to the first chroma when there is no match

Thomas Guillem thomas at gllm.fr
Mon Nov 21 15:49:40 CET 2016


This fixes jpeg playback with xvideo.
---
 modules/video_output/xcb/xvideo.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/modules/video_output/xcb/xvideo.c b/modules/video_output/xcb/xvideo.c
index dde4f33..3f5b15d 100644
--- a/modules/video_output/xcb/xvideo.c
+++ b/modules/video_output/xcb/xvideo.c
@@ -310,7 +310,9 @@ FindFormat (vlc_object_t *obj, xcb_connection_t *conn, video_format_t *fmt,
             continue; /* OMAP framebuffer sucks at YUV 4:2:0 */
         }
 
-        if (!BetterFormat (chroma, chromav, &rank))
+        /* The attr check allows to fallback to the first chroma even if there
+         * is no match (and have a video filter converting the chroma). */
+        if (!BetterFormat (chroma, chromav, &rank) && attr != NULL)
             continue;
 
         xcb_xv_query_image_attributes_reply_t *i;
-- 
2.9.3



More information about the vlc-devel mailing list