[vlc-devel] [PATCH] dtv multisat: Extend support for up to 16 uncommitted ports.

[Jean-Baptiste Kempf]

Hello,

On Sun, 20 Nov 2016, at 18:12, Zoran Turalija wrote:
> -#define UNCOMMITTED_TEXT N_("Uncommitted DiSEqC LNB number")
> +#define UNCOMMITTED_TEXT N_("Uncommitted DiSEqC port number")

Is that really meaningful?

>  #define UNCOMMITTED_LONGTEXT N_( \
>      "If the satellite receiver is connected to multiple " \
> -    "low noise block-downconverters (LNB) through a cascade formed from
> " \
> -    "DiSEqC 1.1 uncommitted switch and DiSEqC 1.0 committed switch, " \
> -    "the correct uncommitted LNB can be selected (1 to 4). " \
> +    "low noise block-downconverters (LNB) through a cascade(s) formed
> from " \
> +    "DiSEqC 1.1 uncommitted switch and DiSEqC 1.0 committed switch(es),
> " \
> +    "the correct uncommitted port can be selected (1 to 16). " \

Please don't do that. Those (s) changes are unnecessary and the (1 to
16) is just keeping the old mistake.

> -        change_integer_list (satno_vlc, satno_user)
> +        change_integer_list (uncommitted_vlc, uncommitted_user)

Is that true on all platforms?



-- 
Jean-Baptiste Kempf -  President
+33 672 704 734