[vlc-devel] [PATCH] dtv multisat: Extend support for up to 16 uncommitted ports.

[Zoran Turalija]

On Tue, Nov 22, 2016 at 09:54:47PM +0100, Jean-Baptiste Kempf wrote:
> Hello,
> 
> On Sun, 20 Nov 2016, at 18:12, Zoran Turalija wrote:
> > -#define UNCOMMITTED_TEXT N_("Uncommitted DiSEqC LNB number")
> > +#define UNCOMMITTED_TEXT N_("Uncommitted DiSEqC port number")
> 
> Is that really meaningful?

IMO it is actually "correct" rather than "really meaningful". You see,
committed DiSEqC switch has output ports that in a majority of real world
cases lead to LNBs (each port to exactly one). So, one can easily substitute
term port/gateway with LNB, as already is the case in VLC. BTW, that is
a result of people using a wrong term, and since a lot of people used that
wrong term, it became a rule.

OTOH uncommitted DiSEqC switch has output ports that in most cases lead
to input ports of committed DiSEqC switches. That means that in most cases
these output ports do not lead to LNBs at all. Hence the term change.

> 
> >  #define UNCOMMITTED_LONGTEXT N_( \
> >      "If the satellite receiver is connected to multiple " \
> > -    "low noise block-downconverters (LNB) through a cascade formed from
> > " \
> > -    "DiSEqC 1.1 uncommitted switch and DiSEqC 1.0 committed switch, " \
> > -    "the correct uncommitted LNB can be selected (1 to 4). " \
> > +    "low noise block-downconverters (LNB) through a cascade(s) formed
> > from " \
> > +    "DiSEqC 1.1 uncommitted switch and DiSEqC 1.0 committed switch(es),
> > " \
> > +    "the correct uncommitted port can be selected (1 to 16). " \
> 
> Please don't do that. Those (s) changes are unnecessary and the (1 to
> 16) is just keeping the old mistake.

Ok, I see what you mean. I dropped plural forms and omitted range values
locally. I kept term changes and I have inserted a comment about them in
a commit message, also locally.

> > -        change_integer_list (satno_vlc, satno_user)
> > +        change_integer_list (uncommitted_vlc, uncommitted_user)
> 
> Is that true on all platforms?

I am not a cross-platform person. Can you advise a better/safer solution?


Thanks for the review.

-- 
Kind regards,
Zoran Turalija